Add star/polygon gizmos and refactor the separate shape drawing tools into a unified Shape tool#2683
Merged
Add star/polygon gizmos and refactor the separate shape drawing tools into a unified Shape tool#2683
Conversation
Keavon
changed the title
Keavon
force-pushed
the
shapes-refactor
branch
2 times, most recently
from
f4f1232 to
f7a870a
Compare
…izmo need to refactor
Keavon
force-pushed
the
master
branch
2 times, most recently
from
34dced3 to
5cacab2
Compare
Keavon
changed the title
Member
|
Issues to address in followup work:
|
Keavon
changed the title
Keavon
changed the title
Keavon
approved these changes
Jun 22, 2025
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
… into a unified Shape tool (GraphiteEditor#2683) * no trait ,not to fix line * add hints * line modification even when other shapes are selected * added transform and anchor overlays * removed old code * fixed transform added hints need to fix modifier keys use * refactored select-tool * add point-handle-gizmo * fix rotate bug * implement angle snapping gizmo , fix overlay and refactor the code * implement snapping for point-handle gizmo and implement no of point gizmo need to refactor * implemented the gizmo for polygon, added tests , brackets to increase sides * formatting-fix * small nit-picks * Make it compile * Code review --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the existing Line, Rectangle, Ellipse, and Polygon tools with a unified Shape Tool that supports the creation of all these shapes from a single interface. The old Line, Rectangle, and Ellipse tools have been aliased to use the new Shape Tool. In addition to shape creation, the new tool also supports modifying the shapes it creates.
Closes #2618, closes #1715